feat: support changing attachment display name #6504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <[email protected]>
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
the
kind/feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6504 +/- ##
============================================
+ Coverage 58.18% 58.24% +0.06%
- Complexity 3774 3777 +3
============================================
Files 651 651
Lines 22125 22128 +3
Branches 1538 1538
============================================
+ Hits 12873 12889 +16
+ Misses 8641 8630 -11
+ Partials 611 609 -2 ☔ View full report in Codecov by Sentry. |
LIlGG
reviewed
Aug 23, 2024
ui/console-src/modules/contents/attachments/components/DisplayNameEditForm.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Wang <[email protected]>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area ui
/kind feature
/milestone 2.19.x
What this PR does / why we need it:
支持修改附件的显示名称。
Fixes #4294
Does this PR introduce a user-facing change?