-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respond not found if no theme template found #6511
Respond not found if no theme template found #6511
Conversation
Signed-off-by: JohnNiang <[email protected]>
Signed-off-by: JohnNiang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6511 +/- ##
============================================
+ Coverage 58.18% 58.37% +0.18%
- Complexity 3774 3790 +16
============================================
Files 651 652 +1
Lines 22125 22161 +36
Branches 1538 1539 +1
============================================
+ Hits 12873 12936 +63
+ Misses 8641 8613 -28
- Partials 611 612 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…grading Spring Boot 3.3.3 (#6515) #### What type of PR is this? /kind bug /area core /milestone 2.19.0 #### What this PR does / why we need it: After merging #6512 and #6511, unit tests fail due to the changes of <spring-projects/spring-boot@05b73ce>. This PR fixes the problem by letting `run.halo.app.infra.exception.handlers.ProblemDetailErrorAttributes` extend `org.springframework.boot.web.reactive.error.DefaultErrorAttributes`. #### Does this PR introduce a user-facing change? ```release-note None ```
What type of PR is this?
/kind improvement
/area core
/milestone 2.19.0
What this PR does / why we need it:
This PR refactors "Template Not Found Exception" into "NotFoundException" to prevent too many exception stacktraces in logs file.
Which issue(s) this PR fixes:
Fixes #6501
Special notes for your reviewer:
Does this PR introduce a user-facing change?