Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize user filter component to support remote search #6529

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 27, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.19.0

What this PR does / why we need it:

重构用户筛选组件,支持远程搜索,避免在用户量大的时候产生性能问题。

image

Does this PR introduce a user-facing change?

重构用户筛选组件,支持远程搜索。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.0 milestone Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wzrove August 27, 2024 03:52
Copy link

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.75%. Comparing base (6cd8dc8) to head (1b0450b).
Report is 26 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6529      +/-   ##
============================================
- Coverage     58.18%   57.75%   -0.44%     
- Complexity     3774     3860      +86     
============================================
  Files           651      668      +17     
  Lines         22125    22829     +704     
  Branches       1538     1584      +46     
============================================
+ Hits          12873    13184     +311     
- Misses         8641     9024     +383     
- Partials        611      621      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

查询用户列表接口更改之后,需要检查一下角色规则配置是否正确。

@ruibaby
Copy link
Member Author

ruibaby commented Aug 27, 2024

查询用户列表接口更改之后,需要检查一下角色规则配置是否正确。

调用这个组件的地方应该已经限制了。

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 25893c0 into halo-dev:main Aug 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants