-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem of LockObtainFailedException while performing a rolling update #6543
Fix the problem of LockObtainFailedException while performing a rolling update #6543
Conversation
…ng update Signed-off-by: JohnNiang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6543 +/- ##
============================================
- Coverage 58.18% 57.77% -0.41%
- Complexity 3774 3876 +102
============================================
Files 651 669 +18
Lines 22125 22917 +792
Branches 1538 1594 +56
============================================
+ Hits 12873 13241 +368
- Misses 8641 9053 +412
- Partials 611 623 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
/milestone 2.19.0
What this PR does / why we need it:
This PR refactors LuceneSearchEngine to let IndexWriter and SearcherManager load lazily to prevent LockObtainFailedException from performing a rolling update.
Which issue(s) this PR fixes:
Fixes #6541
Special notes for your reviewer:
server.port
and start another instance of HaloDoes this PR introduce a user-facing change?