Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent anonymous extensions from being filtered due to duplicate names #6548

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 29, 2024

What type of PR is this?

/kind bug
/area editor
/milestone 2.19.x

What this PR does / why we need it:

为匿名的 Extension 添加 name 值,解决由于匿名的 Extension name 相同而导致被过滤的问题。

How to test it?

测试默认编辑器附件库是否可以被打开。

Does this PR introduce a user-facing change?

解决默认编辑器附件库无法被打开的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 29, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Aug 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and wzrove August 29, 2024 08:21
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Copy link

f2c-ci-robot bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
Copy link

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.93%. Comparing base (6cd8dc8) to head (1e0e37e).
Report is 39 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6548      +/-   ##
============================================
- Coverage     58.18%   57.93%   -0.25%     
- Complexity     3774     3878     +104     
============================================
  Files           651      670      +19     
  Lines         22125    22866     +741     
  Branches       1538     1550      +12     
============================================
+ Hits          12873    13248     +375     
- Misses         8641     9010     +369     
+ Partials        611      608       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit 9c9ac1b into halo-dev:main Aug 29, 2024
8 checks passed
@LIlGG LIlGG deleted the fix/attachment-extension-invaild branch August 29, 2024 11:57
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants