-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve error when deleting images in default editor #6551
Conversation
commit: @halo-dev/api-client
@halo-dev/components
@halo-dev/richtext-editor
@halo-dev/console-shared
@halo-dev/ui-plugin-bundler-kit
|
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6551 +/- ##
============================================
- Coverage 58.18% 57.93% -0.25%
- Complexity 3774 3878 +104
============================================
Files 651 670 +19
Lines 22125 22866 +741
Branches 1538 1550 +12
============================================
+ Hits 12873 13248 +375
- Misses 8641 9010 +369
+ Partials 611 608 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area editor
/area ui
/milestone 2.19.x
What this PR does / why we need it:
在上传的文件中执行
resetUpload
方法之前,提前验证是否可以进行更新。How to test it?
测试删除图片或变更图片位置时,默认编辑器是否会进行报错。
Does this PR introduce a user-facing change?