Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redirect to original image if thumbnail is inaccessible #6556

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Aug 30, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.19.x

What this PR does / why we need it:

获取缩略图时检查缩略图链接是否可访问否则重定向到原图链接

Does this PR introduce a user-facing change?

获取缩略图时检查缩略图链接是否可访问否则重定向到原图链接

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 30, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 30, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang August 30, 2024 07:09
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 30, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG August 30, 2024 07:09
Copy link

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.98%. Comparing base (6cd8dc8) to head (5dd91e6).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
...ore/attachment/impl/LocalThumbnailServiceImpl.java 0.00% 2 Missing ⚠️
...run/halo/app/theme/endpoint/ThumbnailEndpoint.java 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6556      +/-   ##
============================================
- Coverage     58.18%   57.98%   -0.20%     
- Complexity     3774     3883     +109     
============================================
  Files           651      670      +19     
  Lines         22125    22880     +755     
  Branches       1538     1551      +13     
============================================
+ Hits          12873    13267     +394     
- Misses         8641     9002     +361     
  Partials        611      611              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 9a0ebda into halo-dev:main Aug 30, 2024
8 checks passed
@guqing guqing deleted the refactor/check-thumb branch August 30, 2024 09:46
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants