-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add warning alert for H2 database on data initialization page #6564
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6564 +/- ##
============================================
- Coverage 58.18% 58.03% -0.15%
- Complexity 3774 3915 +141
============================================
Files 651 670 +19
Lines 22125 22954 +829
Branches 1538 1573 +35
============================================
+ Hits 12873 13322 +449
- Misses 8641 9015 +374
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind improvement
/milestone 2.19.0
What this PR does / why we need it:
将 H2 数据库使用警告放置在数据初始化页面,之前放在初始化表单页面无法正确判断,因为没有登录,无法调用 /actuator/info 接口获取数据库数据。
Fixes #6561
Special notes for your reviewer:
需要使用此 PR 测试使用 H2 数据库全新安装,观察是否在数据初始化页面有 H2 数据库的使用提示。
Does this PR introduce a user-facing change?