[release-2.19] fix: formkit select component not emitting event or updating selection on value change #6610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on value change (halo-dev#6602) #### What type of PR is this? /kind bug /area ui /milestone 2.20.x #### What this PR does / why we need it: 重新修改 formkit select 初始化值的监听方式，用于当 value 发生变化时，使选项值可以发生变化。 另外在更新数据时，如果数据发生变化，则发出 `onChange` 事件。 > 需要注意的是，通过 v-modal 传入默认值，再将此值改为 `undefined` 时无法触发 `watch` 及 formkit 的 `input` 事件，原因暂时未知，将此值设置为 `""` 即可正常触发。 #### How to test it? 由于此 PR 改动了初始化的方式，因此需要全量测试所有使用 `Select` 组件的位置。包括多选与单选，本地源与远程源。确保功能符合预期。 #### Which issue(s) this PR fixes: Fixes halo-dev#6594 #### Does this PR introduce a user-facing change? ```release-note 解决 Formkit Select 组件在值变更时不会发出事件及修改选项值的问题。 ```
f2c-ci-robot
bot
added
the
release-note
|
LIlGG
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.19 #6610 +/- ##
===============================================
Coverage ? 58.06%
Complexity ? 3916
===============================================
Files ? 670
Lines ? 22966
Branches ? 1575
===============================================
Hits ? 13335
Misses ? 9015
Partials ? 616 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6602
/assign LIlGG