-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent null role while getting permissions #6612
Conversation
Signed-off-by: JohnNiang <[email protected]>
/cherrypick release-2.19 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6612 +/- ##
============================================
- Coverage 58.18% 58.07% -0.12%
- Complexity 3774 3916 +142
============================================
Files 651 670 +19
Lines 22125 22970 +845
Branches 1538 1575 +37
============================================
+ Hits 12873 13339 +466
- Misses 8641 9015 +374
- Partials 611 616 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JohnNiang: new pull request created: #6613 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #6612 /assign JohnNiang ```release-note 修复取消用户角色后无法正常渲染用户列表的问题 ```
What type of PR is this?
/kind bug
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR filters blank role name while granting roles for an user to prevent null role in permissions.
Which issue(s) this PR fixes:
Fixes #6604
Does this PR introduce a user-facing change?