Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent null role while getting permissions #6612

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR filters blank role name while granting roles for an user to prevent null role in permissions.

Which issue(s) this PR fixes:

Fixes #6604

Does this PR introduce a user-facing change?

修复取消用户角色后无法正常渲染用户列表的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Sep 6, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 6, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 6, 2024
@JohnNiang
Copy link
Member Author

/cherrypick release-2.19

@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen September 6, 2024 13:45
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

sonarqubecloud bot commented Sep 6, 2024

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.07%. Comparing base (6cd8dc8) to head (5551ef5).
Report is 57 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6612      +/-   ##
============================================
- Coverage     58.18%   58.07%   -0.12%     
- Complexity     3774     3916     +142     
============================================
  Files           651      670      +19     
  Lines         22125    22970     +845     
  Branches       1538     1575      +37     
============================================
+ Hits          12873    13339     +466     
- Misses         8641     9015     +374     
- Partials        611      616       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
Copy link

f2c-ci-robot bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 93ffb7d into halo-dev:main Sep 6, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #6613

In response to this:

/cherrypick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang JohnNiang deleted the bug/null-role-in-roles branch September 6, 2024 14:08
f2c-ci-robot bot pushed a commit that referenced this pull request Sep 6, 2024
This is an automated cherry-pick of #6612

/assign JohnNiang

```release-note
修复取消用户角色后无法正常渲染用户列表的问题
```
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

为用户设置一个为空的角色会导致角色列表报错
3 participants