-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve incorrect display of options in formkit selector with async data #6629
Conversation
/cherrypick release-2.19 |
@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6629 +/- ##
============================================
- Coverage 58.18% 58.05% -0.13%
- Complexity 3774 3916 +142
============================================
Files 651 670 +19
Lines 22125 22970 +845
Branches 1538 1575 +37
============================================
+ Hits 12873 13335 +462
- Misses 8641 9019 +378
- Partials 611 616 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…ct-sync-options
Quality Gate passedIssues Measures |
/lgtm |
@LIlGG: #6629 failed to apply on top of branch "release-2.19":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ync data (halo-dev#6629) #### What type of PR is this? /kind bug /area ui /milestone 2.20.x #### What this PR does / why we need it: 为 formkit select 组件优化逻辑,目前将可以监听到 options 的变化,用于在变化时设置值。用于解决当 options 是异步获取,而 value 是初始设置时,无法显示正常的 label。 #### How to test it? 测试 options 比设置 value 晚时,数据能否正常显示 label。 #### Does this PR introduce a user-facing change? ```release-note 解决当 formkit select 组件中的 options 延迟设置时无法正常回显的问题。 ```
What type of PR is this?
/kind bug
/area ui
/milestone 2.20.x
What this PR does / why we need it:
为 formkit select 组件优化逻辑,目前将可以监听到 options 的变化,用于在变化时设置值。用于解决当 options 是异步获取,而 value 是初始设置时,无法显示正常的 label。
How to test it?
测试 options 比设置 value 晚时,数据能否正常显示 label。
Does this PR introduce a user-facing change?