Expose CryptoService and RateLimiterRegistry to plugins #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JohnNiang <[email protected]>
f2c-ci-robot
bot
added
kind/feature
f2c-ci-robot
bot
added
the
area/plugin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6638 +/- ##
============================================
- Coverage 58.18% 58.05% -0.13%
- Complexity 3774 3917 +143
============================================
Files 651 670 +19
Lines 22125 22980 +855
Branches 1538 1576 +38
============================================
+ Hits 12873 13341 +468
- Misses 8641 9022 +381
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
|
/ping @halo-dev/sig-halo |
|
/sig docs |
f2c-ci-robot
bot
added
the
sig/docs
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
deleted the
feat/expose-crypto-service-and-ratelimiterregistry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area core
/area plugin
/milestone 2.20.x
What this PR does / why we need it:
Currently, we are refactoring login and logout pages to make them extensible. If plugins want to realize a new authentication method, the CryptoService and RateLimiterRegistry may be used to authenticate.
So this PR exposes the two beans to plugins. No side effect will be introduced.
Does this PR introduce a user-facing change?