-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support changing locale using query language #6658
Support changing locale using query language #6658
Conversation
Signed-off-by: JohnNiang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6658 +/- ##
============================================
- Coverage 58.18% 58.12% -0.06%
- Complexity 3774 3928 +154
============================================
Files 651 674 +23
Lines 22125 23060 +935
Branches 1538 1574 +36
============================================
+ Hits 12873 13404 +531
- Misses 8641 9039 +398
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR adds support changing locale using query
language
. After passing the query, we will automatically respond a cookielanguage
back to browser.Please see the result below:
Does this PR introduce a user-facing change?