-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: exclude indices directory during backup #6753
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6753 +/- ##
============================================
- Coverage 58.29% 57.88% -0.41%
- Complexity 3963 4007 +44
============================================
Files 680 709 +29
Lines 23338 23831 +493
Branches 1584 1574 -10
============================================
+ Hits 13604 13794 +190
- Misses 9108 9415 +307
+ Partials 626 622 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
需要注意的是,恢复重启之后可能导致搜索到以前的文章。因为恢复过程中并没有删除已有的索引。
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area core
/kind improvement
/milestone 2.20.x
What this PR does / why we need it:
备份时排除全文索引目录 indices,防止恢复之后因为索引文件问题无法启动。
Which issue(s) this PR fixes:
Fixes #6443
Does this PR introduce a user-facing change?