-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pref: remove anonymous and ghost users from the userSelect #6781
pref: remove anonymous and ghost users from the userSelect #6781
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6781 +/- ##
============================================
- Coverage 58.00% 57.88% -0.13%
- Complexity 3977 4016 +39
============================================
Files 696 709 +13
Lines 23517 23851 +334
Branches 1567 1574 +7
============================================
+ Hits 13641 13806 +165
- Misses 9255 9423 +168
- Partials 621 622 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area ui
/milsetone 2.20.x
What this PR does / why we need it:
在 userSelect 查询用户列表时,移除匿名与已删除用户这两个保留用户。
How to test it?
在文章设置,用户列表中不存在匿名与已删除用户即可。
Which issue(s) this PR fixes:
Fixes #6665
Does this PR introduce a user-facing change?