Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: remove anonymous and ghost users from the userSelect #6781

Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Oct 8, 2024

What type of PR is this?

/kind improvement
/area ui
/milsetone 2.20.x

What this PR does / why we need it:

在 userSelect 查询用户列表时,移除匿名与已删除用户这两个保留用户。

How to test it?

在文章设置,用户列表中不存在匿名与已删除用户即可。

Which issue(s) this PR fixes:

Fixes #6665

Does this PR introduce a user-facing change?

在用户选择组件中不再显示匿名与已删除用户。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and JohnNiang October 8, 2024 03:13
Copy link

sonarqubecloud bot commented Oct 8, 2024

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.88%. Comparing base (5b2bdfd) to head (47aeedb).
Report is 32 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6781      +/-   ##
============================================
- Coverage     58.00%   57.88%   -0.13%     
- Complexity     3977     4016      +39     
============================================
  Files           696      709      +13     
  Lines         23517    23851     +334     
  Branches       1567     1574       +7     
============================================
+ Hits          13641    13806     +165     
- Misses         9255     9423     +168     
- Partials        621      622       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
@ruibaby ruibaby added this to the 2.20.x milestone Oct 8, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f632322 into halo-dev:main Oct 8, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章高级设置有不存在的用户
3 participants