Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct display of email verification message toast #6822

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 11, 2024

What type of PR is this?

/area core
/kind bug
/milestone 2.20.x

What this PR does / why we need it:

修复不能正常显示邮箱验证提示的问题。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note-none Denotes a PR that doesn't merit a release note. labels Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen October 11, 2024 09:01
Copy link

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.07%. Comparing base (d7aba83) to head (7b0a5bd).
Report is 22 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6822      +/-   ##
============================================
+ Coverage     57.03%   57.07%   +0.03%     
- Complexity     3978     3988      +10     
============================================
  Files           713      714       +1     
  Lines         23992    24042      +50     
  Branches       1570     1576       +6     
============================================
+ Hits          13685    13723      +38     
- Misses         9696     9706      +10     
- Partials        611      613       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link

f2c-ci-robot bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit d63eaed into halo-dev:main Oct 11, 2024
8 checks passed
@ruibaby ruibaby deleted the fix/email-empty-validation-message branch October 11, 2024 09:27
@JohnNiang JohnNiang modified the milestones: 2.20.x, 2.20.0 LTS Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants