Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add globalInfo into templates model #6823

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Oct 11, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR adds globalInfo into template models and refactors password reset to adapt data binding.

Fixes #6821

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen October 11, 2024 09:40
Copy link

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 2.81690% with 69 lines in your changes missing coverage. Please review.

Project coverage is 57.03%. Comparing base (d7aba83) to head (bd04e01).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...ity/preauth/PreAuthEmailPasswordResetEndpoint.java 2.89% 67 Missing ⚠️
...app/security/preauth/PreAuthTwoFactorEndpoint.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6823      +/-   ##
============================================
- Coverage     57.03%   57.03%   -0.01%     
- Complexity     3978     3989      +11     
============================================
  Files           713      714       +1     
  Lines         23992    24058      +66     
  Branches       1570     1578       +8     
============================================
+ Hits          13685    13722      +37     
- Misses         9696     9724      +28     
- Partials        611      612       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 98a1313 into halo-dev:main Oct 11, 2024
8 checks passed
@JohnNiang JohnNiang deleted the refactor/add-globalinfo-to-template-model branch October 11, 2024 10:18
@JohnNiang JohnNiang modified the milestones: 2.20.x, 2.20.0 LTS Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

找回密码相关页面没有提供 globalInfo 变量
3 participants