Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify name column charset to make it case-sensitive for MySQL #6897

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 18, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

将 MySQL 的表创建脚本 name 列字符集改为 utf8mb4_bin 以使其对大小写敏感

Fixes #4372

how to test it?
使用 docker 运行 MySQL

# mariadb 同样将镜像改为 mariadb 后执行相同步骤
docker run --name mysql-test -e MYSQL_ROOT_PASSWORD=root -e MYSQL_DATABASE=halo -p 3306:3306 --rm -d mysql:latest

然后执行表创建脚本并手动执行以下两条 SQL 能成功插入

insert into extensions(name,data,version) values('a', 'a', 0)
insert into extensions(name,data,version) values('A', 'A', 0)

Does this PR introduce a user-facing change?

修改 MySQL 表创建脚本 name 列的字符集使其大小写敏感,以保证和其他数据库表现一致

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen October 18, 2024 08:33
@guqing guqing changed the title fix: modify name column charset to make it case-sensitive for mysql fix: modify name column charset to make it case-sensitive for MySQL Oct 18, 2024
Copy link

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.21%. Comparing base (eff73dc) to head (22c385a).
Report is 20 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6897      +/-   ##
============================================
+ Coverage     56.99%   57.21%   +0.22%     
- Complexity     3999     4004       +5     
============================================
  Files           714      712       -2     
  Lines         24110    24109       -1     
  Branches       1585     1592       +7     
============================================
+ Hits          13742    13795      +53     
+ Misses         9756     9699      -57     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 833b884 into halo-dev:main Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用 MySQL 作为数据库时根据名称查询为大小写不敏感
2 participants