-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: post slug generation not following selected strategy #6914
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6914 +/- ##
============================================
+ Coverage 56.99% 57.21% +0.22%
- Complexity 3999 4005 +6
============================================
Files 714 712 -2
Lines 24110 24113 +3
Branches 1585 1592 +7
============================================
+ Hits 13742 13797 +55
+ Misses 9756 9701 -55
- Partials 612 615 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新建页面并直接保存后,问题似乎仍然存在。
请参考:#6118 (comment) 我不认为页面也需要自动生成别名。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind bug
/milestone 2.20.x
What this PR does / why we need it:
修复文章自动生成别名不按照别名生成策略生成的问题。
Which issue(s) this PR fixes:
Fixes #6913
Special notes for your reviewer:
需要测试:
Does this PR introduce a user-facing change?