Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post slug generation not following selected strategy #6914

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 22, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.20.x

What this PR does / why we need it:

修复文章自动生成别名不按照别名生成策略生成的问题。

Which issue(s) this PR fixes:

Fixes #6913

Special notes for your reviewer:

需要测试:

  1. 分类、标签创建和更新时的别名生成
  2. 文章新建时,别名是否按照生成策略生成。

Does this PR introduce a user-facing change?

修复文章自动生成别名不按照别名生成策略生成的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Oct 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 22, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 22, 2024
Copy link

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.21%. Comparing base (eff73dc) to head (cf08108).
Report is 24 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6914      +/-   ##
============================================
+ Coverage     56.99%   57.21%   +0.22%     
- Complexity     3999     4005       +6     
============================================
  Files           714      712       -2     
  Lines         24110    24113       +3     
  Branches       1585     1592       +7     
============================================
+ Hits          13742    13797      +55     
+ Misses         9756     9701      -55     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新建页面并直接保存后,问题似乎仍然存在。

@ruibaby
Copy link
Member Author

ruibaby commented Oct 22, 2024

新建页面并直接保存后,问题似乎仍然存在。

请参考:#6118 (comment)

我不认为页面也需要自动生成别名。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
Copy link

f2c-ci-robot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 9ecc8f1 into halo-dev:main Oct 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
3 participants