-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/change user role and delete #6960
Feature/change user role and delete #6960
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
@@ -44,6 +44,18 @@ const modalTitle = props.group | |||
const handleSave = async () => { | |||
try { | |||
isSubmitting.value = true; | |||
const existingGroupsResponse = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
包含了 #6959 中的更改,建议新的改动新开一个分支再提交 PR,可以看看这个文档:https://docs.halo.run/contribution/pr#%E4%BB%A3%E7%A0%81%E8%B4%A1%E7%8C%AE%E6%AD%A5%E9%AA%A4
@@ -47,6 +47,14 @@ const formState = ref<Policy>({ | |||
|
|||
const isUpdateMode = !!props.policy; | |||
|
|||
const { data: policies } = useQuery({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
@@ -135,6 +143,14 @@ const submitting = ref(false); | |||
const handleSave = async () => { | |||
try { | |||
submitting.value = true; | |||
const nameExists = policies.value?.items.some( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
@@ -143,14 +143,14 @@ const onGroupEditingModalClose = async () => { | |||
@click="selectedGroupName = group.metadata.name" | |||
/> | |||
|
|||
<AttachmentGroupBadge @click="handleOpenCreateNewGroupModal"> | |||
<AttachmentPolicyBadge @click="handleOpenCreateNewGroupModal"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
/kind improvement
Fixes #6944