Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/change user role and delete #6960

Closed

Conversation

LEIYOUSU
Copy link
Contributor

/kind improvement
Fixes #6944

Copy link

f2c-ci-robot bot commented Oct 28, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Oct 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen October 28, 2024 12:47
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 28, 2024
Copy link

f2c-ci-robot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilgg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@@ -44,6 +44,18 @@ const modalTitle = props.group
const handleSave = async () => {
try {
isSubmitting.value = true;
const existingGroupsResponse =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

包含了 #6959 中的更改,建议新的改动新开一个分支再提交 PR,可以看看这个文档:https://docs.halo.run/contribution/pr#%E4%BB%A3%E7%A0%81%E8%B4%A1%E7%8C%AE%E6%AD%A5%E9%AA%A4

@@ -47,6 +47,14 @@ const formState = ref<Policy>({

const isUpdateMode = !!props.policy;

const { data: policies } = useQuery({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@@ -135,6 +143,14 @@ const submitting = ref(false);
const handleSave = async () => {
try {
submitting.value = true;
const nameExists = policies.value?.items.some(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@@ -143,14 +143,14 @@ const onGroupEditingModalClose = async () => {
@click="selectedGroupName = group.metadata.name"
/>

<AttachmentGroupBadge @click="handleOpenCreateNewGroupModal">
<AttachmentPolicyBadge @click="handleOpenCreateNewGroupModal">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@LEIYOUSU LEIYOUSU closed this Oct 29, 2024
@LEIYOUSU LEIYOUSU deleted the feature/change-user-role-and-delete branch October 29, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望支持在用户详情页面支持变更用户角色及删除用户
2 participants