Improve ldiff binary support #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Annih This will need to be rebased to be merged. |
halostatue
approved these changes
Feb 2, 2025
This was
linked to
issues
Feb 2, 2025
auto-merge was automatically disabled
February 2, 2025 18:35
Head branch was pushed to by a user without write access
Annih
force-pushed
the
improve_ldiff_binary_support
branch
from
28de1fb to
b098fc8
Compare
Before this change, the comparison was reversed and diff were not detected. This commit also change the output when a diff is detected to look like the GNU diff output. Also fix the support of all other format than :report, by quickly halting the diff process if there is a binary diff.
Annih
force-pushed
the
improve_ldiff_binary_support
branch
from
b098fc8 to
6f7313e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the comparison was reversed and diff were not detected. (See #102)
This commit also change the output when a diff is detected to look like the GNU diff output.
Also fix the support of all other format than :report, by quickly halting the diff process if there is a binary diff.