Fix an issue caused by detecting the encoding when first data ia empty #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge this as soon as I file a bug with Rubinius for the failed build in 1.9 mode—I need to be able to make a test case for them to see the problem in a somewhat better way. I'm treating it similar to the MacRuby issue; everyone else gets it right, why doesn't rbx? That should be by the afternoon, and I'll do a release this evening. |
halostatue
added a commit
that referenced
this pull request
Apr 11, 2013
Fix an issue caused by detecting the encoding when first data is empty
|
Hey thanks! Could you ping me (via mention or whatever) when you've rolled a release? We're awaiting it over on RSpec :) |
|
@JonRowe the release is complete. |
|
Thanks @halostatue! Appreciate it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first data passed to
Diff::LCS::Hunkis empty then we get an error due to the encoding detection introduced in 1.2.2.This attempts to use the old data as an encoding source, falls back to the new data as an encoding source and then finally to a string literal.