Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #188

Closed
wants to merge 3 commits into from
Closed

Update docs #188

wants to merge 3 commits into from

Conversation

xaviershay
Copy link
Contributor

See #134

I wrote this as if all the issues I just filed were fixed. I intend that to be true by the end of the weekend.

@xaviershay
Copy link
Contributor Author

Actually hold off merging this, I'll just add all the other edits here as well.

@xaviershay xaviershay changed the title Update docs for Vector Update docs for Vector and Set Aug 15, 2015
@xaviershay xaviershay changed the title Update docs for Vector and Set Update docs Aug 16, 2015
@xaviershay
Copy link
Contributor Author

Ready for review.

@alexdowad
Copy link
Contributor

Wow, wow, wow. I didn't notice you had added so much here. Let me look through.

@alexdowad
Copy link
Contributor

This was a lot of work! Thank you!! Let me go ahead and cherry-pick everything which is ready for merging right now.

@alexdowad
Copy link
Contributor

I've merged most of these commits. Will comment on the ones which are not merged yet tomorrow. Thanks!!

@xaviershay
Copy link
Contributor Author

I think I've responded to all feedback.

@alexdowad
Copy link
Contributor

Just added some more feedback.

@alexdowad
Copy link
Contributor

OK, I've merged the last 3 commits (with a couple tiny edits). Thank you!! Great job!!

@alexdowad alexdowad closed this Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xaviershay @alexdowad