[실습] 연습문제 week1/03 제출합니다 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooooo1
reviewed
Aug 10, 2023
| capitalized.push(words[i].toLowerCase()) | ||
| } | ||
| } | ||
| const condition = (text: string, criteria = 5) => text.length > criteria |
There was a problem hiding this comment.
condition 함수의 이름이 조금 추상적으로 느껴져서
Suggested change
| const condition = (text: string, criteria = 5) => text.length > criteria | |
| const isLongerThanCriteria = (text: string, criteria = 5) => text.length > criteria |
is 프리픽스로 boolean임을 더욱 분명하게 알려주는 구체적인 네이밍 isLongerThanCriteria도 좋을 것 같아요
There was a problem hiding this comment.
아 너무 명확하네요 ㅠㅠ 좋습니다 충일님!! 반영하겠습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
접근 방법:
앞선 문제들과 비슷하게, 순수함수를 뽑고,
map을 활용해서 copy on write 방식을 적용해봤습니다.
💬 질문 사항이에요
🤷♂️ 확인 받고 싶은 부분이에요
🔥 이건 꼭 확인해주세요