Support PHP 8 #8
Conversation
|
@kevinpapst thx for having a look at this. I did upgrade the tests. Lets hope they will now also run on travis. We will replace travis soon with github actions, so we will not invest to many time into travis here. |
|
Wow, that escalated quickly 😁 I guess the time of free Travis jobs is over - it is running for more than an hour now. Insane... |
|
@kevinpapst seems like the free time is really over: https://travis-ci.com/github/handcraftedinthealps/RestRoutingBundle/builds/209334957 Did test it locally with php8 and the test did finish there so I will merge and tag this. Thank you for adding PHP8 Support here! |
|
Tagged as 1.0.1 |
|
I tested the new tag (but not your test code changes) locally with 7.4 and 8.0 and in Github actions with 7.2/7.3/7.4/8.0 Works. Thanks for the quick merge 🎉 |
This PR adds very basic PHP 8 support.
All credits go to @GuilhemN who added that code to FOSRestBundle in the last release, see here: FriendsOfSymfony/FOSRestBundle@2.8.3...2.8.4 (or the original rfc)
I changed the check for
if (defined('T_NAME_QUALIFIED')) {with a check for the PHP Version, becuase this is more failsafe.There are at least 2 projects outside, which do define this constant in user land code, see here and here.
Open: