Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for NodeJS compatibility #1501

Merged
merged 1 commit into from
Feb 18, 2019
Merged

test: add test for NodeJS compatibility #1501

merged 1 commit into from
Feb 18, 2019

Conversation

nknapp
Copy link
Collaborator

@nknapp nknapp commented Feb 17, 2019

The test is a simple addition to the existing tests. It should ensure
that the built Handlebars artifact only uses language features that are
available in old versions of NodeJS. A simple program and the
precompiler are started with NodeJS 0.10 to 11

Before creating a pull-request, please check https://github.com/wycats/handlebars.js/blob/master/CONTRIBUTING.md first.

Generally we like to see pull requests that

  • Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
  • Maintain the existing code style
  • Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
  • Have good commit messages
  • Have tests
  • Have the typings (lib/handlebars.d.ts) updated on every API change. If you need help, updating those, please mention that in the PR description.
  • Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
  • Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

The test is a simple addition to the existing tests. It should ensure
that the built Handlebars artifact only uses language features that are
available in old versions of NodeJS. A simple program and the
precompiler are started with NodeJS 0.10 to 11
@nknapp nknapp changed the base branch from master to 4.x February 17, 2019 22:05
@nknapp nknapp merged commit b92589a into 4.x Feb 18, 2019
@nknapp nknapp deleted the multi-node-test branch February 18, 2019 18:21
@handlebars-lang handlebars-lang deleted a comment from hady2 Feb 19, 2019
@handlebars-lang handlebars-lang deleted a comment from hady2 Feb 19, 2019
@handlebars-lang handlebars-lang deleted a comment from hady2 Feb 19, 2019
@nknapp
Copy link
Collaborator Author

nknapp commented Feb 19, 2019

@hady2 I deleted your comments because they read like spam and did not make any sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant