Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: update bdb to 1.5.1 and use @handshake-org/bfilter. #851

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

nodech
Copy link
Contributor

@nodech nodech commented Sep 27, 2023

  • Updated bfilter
    • bfilter has been behind and was using old mrmr, new one uses bcrypto mrmr.
    • Forked https://github.com/bcoin-org/bfilter/ - original is using git dependencies. Until we decide to move everything away from npm, it's better to use npm than mix.
  • updated bdb
    • Updated bdb which fixes several segfaults caused by incorrect guards inside it.
    • bdb now has async iterators.
  • Fix the test case, which suffered from the previous segfaults by of wdb.close/sync race condition. After bdb update, it manifested as iterators has already ended error.

@coveralls
Copy link

Coverage Status

coverage: 68.646% (+0.02%) from 68.623% when pulling 1cc63b5 on nodech:update-bdb into 4e87fb1 on handshake-org:master.

@nodech nodech merged commit 2ede2c2 into handshake-org:master Sep 28, 2023
@nodech nodech deleted the update-bdb branch September 28, 2023 07:48
@nodech nodech mentioned this pull request Oct 16, 2023
@nodech nodech mentioned this pull request Nov 29, 2024
@nodech nodech mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants