Wallet: add tests for the chain state and fix markState #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodech
added
wallet
|
From latest commit comment - fixes two issues:
|
nodech
changed the title
Fixes two markState issues:
- On close/crash of walletdb on add block wdb state would have
incorrect state for the startHeight/startHash and mark. WalletDB
could end up having incorrect startHeight/startHash for the rest
of the walletDB until rescan before height. Check the
wallet-chainstate-test case for corruption.
- On the specific height where the walletDB received first
transaction, state.height would also be incorrect (only for one
block).
nodech
force-pushed
the
wallet-test-chainstate
branch
from
bed5f09 to
2601f3c
Compare
rithvikvibhu
approved these changes
Dec 3, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of review for this: #622
Only adds test cases to the codebase related to chain state. Does not fix/change anything.
Covers discovered bug which is currently skipped. There's bug related to corruption but it's currently skipped as it's not solved.
More discussion on the issue.