Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chain: remove unnecessary critical error. #873

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chain: remove unnecessary critical error. #873

merged 1 commit into from
Nov 9, 2023

Conversation

nodech
Copy link
Contributor

@nodech nodech commented Nov 8, 2023 •
edited
Loading

Clean up the errors. No need for it to be critical.

@nodech nodech added blockchain part of the codebase cleanup improvement classification labels Nov 8, 2023
@coveralls
Copy link

Coverage Status

coverage: 68.614% (+0.02%) from 68.596%
when pulling 9df05ac on nodech:remove-critical
into 6446828 on handshake-org:master.

@nodech nodech merged commit e3e5e01 into handshake-org:master Nov 9, 2023
6 checks passed
nodech added a commit that referenced this pull request Nov 9, 2023
@nodech
Merge PR #873 from 'nodech/remove-critical'
86d8f6f
@nodech nodech deleted the remove-critical branch November 9, 2023 11:48
@nodech nodech mentioned this pull request Nov 29, 2024
Merged
@nodech nodech mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blockchain part of the codebase cleanup improvement classification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nodech @coveralls