Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup #881

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Test cleanup #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81e5c84
test: rename contexts and simplify.
nodech Dec 14, 2023
6102ad5
test: refactor http-test to relevant files.
nodech Dec 15, 2023
a2d7e3c
test: add mineBlocks to node context.
nodech Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/primitives/address.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ class Address extends bio.Struct {

/**
* Compile the address object to a bech32 address.
* @param {{NetworkType|Network)?} network
* @param {(NetworkType|Network)?} network
* @returns {String}
* @throws Error on bad hash/prefix.
*/
Expand Down
6 changes: 2 additions & 4 deletions test/auction-rpc-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const {
Path
} = require('..');
const {forValue} = require('./util/common');
const NodeContext = require('./util/node');
const NodeContext = require('./util/node-context');

class TestUtil {
constructor() {
Expand Down Expand Up @@ -52,7 +52,7 @@ class TestUtil {

await this.nodeCtx.open();

this.node.plugins.walletdb.wdb.on('confirmed', ((details, tx) => {
this.nodeCtx.wdb.on('confirmed', ((details, tx) => {
const txid = tx.txid();

if (!this.txs[txid])
Expand Down Expand Up @@ -416,8 +416,6 @@ describe('Auction RPCs', function() {

describe('SPV', function () {
const spvCtx = new NodeContext({
port: 10000,
brontidePort: 20000,
httpPort: 30000,
only: '127.0.0.1',
noDns: true,
Expand Down
Loading