Wallet Sync Updates #883
Merged
Wallet Sync Updates #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodech
force-pushed
the
wallet-interactive-rescan
branch
from
a32818e to
a3cb91d
Compare
nodech
force-pushed
the
wallet-interactive-rescan
branch
from
a3cb91d to
ac1f9c6
Compare
nodech
force-pushed
the
wallet-interactive-rescan
branch
2 times, most recently
from
75f3a42 to
2b44a64
Compare
nodech
force-pushed
the
wallet-interactive-rescan
branch
from
7bc97f7 to
a4d0b01
Compare
nodech
force-pushed
the
wallet-interactive-rescan
branch
from
a4d0b01 to
c9c6f4b
Compare
nodech
added
wallet
|
Note on #831. The PR and the commit tries to attempt synchronizing filter when running in SPV mode. Unfortunately, that's not going to work. The SPV add filter/set filter on Fullnode wallets can use rescan feature introduced in this PR to properly resolve the transactions, this does not change/fix add blocks on normal sync. |
wallet-node: fix standalone wallet get entry requests when entry is not found on chain. client: expose Wallet class.
Interactive rescan by default does per block scan lock. This enables parallel rescans, as well as chain sync while rescan is in progress. But in specific cases, it may be more beneficial to stop the node from syncing while the rescan is in progress.
wdb/client: fix standalone ChainEntry deserialization and add prevBlock.
bsock hooks that nodeclient tries to imitate, are handlers set on specific event. They are expected to return results to the caller.
Add stack traces to common test helper timeouts. Change default timeout to 2000.
nodech
force-pushed
the
wallet-interactive-rescan
branch
from
fc8df20 to
f46192d
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet Sync Updates
Node HTTP
fullLockoption to the interactive scan, that locks the whole chainwhile scan is in progress.
Wallet
openandcloseevents.Wallet Client
Wallettogether withWalletClientasWalletClient.Wallet.Not changelog related
wdb.addBlock guards.
Add more guards around
wdb.addBlock. Make sure we did not receive incorrectblock accidentally. This change makes sure:
ensuring we are on the same chain.
Currently, it does nothing to change the behaviour. But it could call
syncChainwhich reorgnizes the walletDB to go back to the same chain. If usersare experiencing any of these logs repeteadly, currently they just need to
restart. syncChain is called on wallet->chain connect. This should not happen
when running wallet as a plugin, but if it ever happened wdb would not have
caught it.
Closes #519
Closes #872
Closes #831