Update Transmute() code in all affected reflection apis, with fix for…

… overlapping metadata tokens, i don't have the OCD to try and reproduce a test case for this, though i have a feeling it would have something to do with the number of classes / fields / members / properties that are delcared inside a single module

bumping version number to 1.3.3

ExpressiveReflection/ConstructorReflection.cs

@@ -24,7 +24,7 @@ public ConstructorInfo Transmute(ConstructorInfo other, params Type[] newGeneric
 
 
             var type = other.DeclaringType.GetGenericTypeDefinition().MakeGenericType(newGenericArgs);
-            var transmuted = type.GetConstructors().Where(c => c.MetadataToken == other.MetadataToken).Single();
+            var transmuted = type.GetConstructors().Where(c => c.MetadataToken == other.MetadataToken && c.Module == other.Module).Single();
             return transmuted;
         }
 

ExpressiveReflection/MemberReflection.cs

@@ -27,7 +27,7 @@ public MemberInfo Transmute(MemberInfo target, params Type[] newGenericArgs)
             }
 
             var type = target.DeclaringType.GetGenericTypeDefinition().MakeGenericType(newGenericArgs);
-            var transmuted = type.GetMembers().Where(m => m.MetadataToken == target.MetadataToken).Single();
+            var transmuted = type.GetMembers().Where(m => m.MetadataToken == target.MetadataToken && m.Module == target.Module).Single();
             return transmuted;
         }
 

ExpressiveReflection/MethodReflection.cs

@@ -36,7 +36,7 @@ public MethodInfo Transmute(MethodInfo target, Type[] typeArgsForType, Type[] ty
                 newType = declaringType;
             }
 
-            var newMethod = newType.GetMethods().Where(m => m.MetadataToken == target.MetadataToken).Single();
+            var newMethod = newType.GetMethods().Where(m => m.MetadataToken == target.MetadataToken && m.Module == target.Module).Single();
             if (newMethod.IsGenericMethodDefinition)
             {
                 newMethod = newMethod.MakeGenericMethod(typeArgsForMethod);

ExpressiveReflection/Package.nuspec

@@ -2,14 +2,15 @@
 <package >
   <metadata>
     <id>ExpressiveReflection</id>
-    <version>1.3.2</version>
+    <version>1.3.3</version>
     <authors>hannasm</authors>
     <owners>hannasm</owners>
 	<licenseUrl>https://github.com/hannasm/ExpressiveReflectionDotnet/blob/master/LICENSE</licenseUrl>
     <projectUrl>https://github.com/hannasm/ExpressiveReflectionDotnet</projectUrl>
     <requireLicenseAcceptance>false</requireLicenseAcceptance>
     <description>Tools to simplify coding with the .NET reflection APIs.</description>
     <releaseNotes>
+      * 1.3.3 - Fix issues with Transmute(), where two separate members defined on the same type have the same metadata toekn, because the two members are declared in different modules and by chance they happened to overlap
       * 1.3.2 - Implemented a MemberReflection.Transmute() method to complement the other Transmute() offerings
       * 1.3.2 - rewrite constructorReflection.Transmute() to use same MetadataToken trick that the MethodReflection.Transmtue() relies on
       * 1.3.1 - Fix for bug in MethodReflection.Transmute() leading to completely random method derivations being returned

ExpressiveReflection/Properties/AssemblyInfo.cs

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.3.2")]
-[assembly: AssemblyFileVersion("1.3.2")]
+[assembly: AssemblyVersion("1.3.3")]
+[assembly: AssemblyFileVersion("1.3.3")]

README.md

@@ -1,11 +1,11 @@
 # Versioning
-This is version 1.3.2 of the expressive reflection library.
+This is version 1.3.3 of the expressive reflection library.
 
-This package is available from nuget at: https://www.nuget.org/packages/ExpressiveReflection/1.3.2
+This package is available from nuget at: https://www.nuget.org/packages/ExpressiveReflection/1.3.3
 
-This package is also available from nuget as an embeddable sources package at: https://www.nuget.org/packages/ExpressiveReflection.Sources/1.3.2
+This package is also available from nuget as an embeddable sources package at: https://www.nuget.org/packages/ExpressiveReflection.Sources/1.3.3
 
-The source for this release is available on github at: https://github.com/hannasm/ExpressiveReflectionDotNet/releases/tag/1.3.2
+The source for this release is available on github at: https://github.com/hannasm/ExpressiveReflectionDotNet/releases/tag/1.3.3
 
 # ExpressiveReflectionDotnet
 This is a .NET library for simplifying reflection / metadata programming and making 
@@ -49,6 +49,9 @@ The ExpressiveReflection.Reflection class exposes all of the reflection methods
 There is a fairly comprehensive set of unit tests, and additionald examples demonstrating functionality can be found there.
 
 # Changelog 
+## 1.3.3
+  * 1.3.3 - Fix issues with Transmute(), where two separate members defined on the same type have the same metadata toekn, because the two members are declared in different modules and by chance they happened to overlap
+
 ## 1.3.2
   * 1.3.2 - Implemented a MemberReflection.Transmute() method to complement the other Transmute() offerings
   * 1.3.2 - rewrite constructorReflection.Transmute() to use same MetadataToken trick that the MethodReflection.Transmtue() relies on