Centralmanager methods #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wilson <[email protected]>
retrievePeripheralsWithIdentifiers & retrieveConnectedPeripheralsWithServices Signed-off-by: wilson <[email protected]>
Signed-off-by: wilson <[email protected]>
hansemannn
requested changes
Jun 21, 2017
|
|
||
| NSMutableArray<TiBluetoothPeripheralProxy*> *result = [NSMutableArray array]; | ||
|
|
||
| for (id peripheral in peripherals) { |
There was a problem hiding this comment.
Change to CBPeripheral *peripheral, since the type is determined by the array template-type
| NSMutableArray<TiBluetoothPeripheralProxy*> *result = [NSMutableArray array]; | ||
|
|
||
| for (id peripheral in peripherals) { | ||
| ENSURE_TYPE(peripheral, CBPeripheral); |
There was a problem hiding this comment.
Remove this as well, see above.
iphone/Classes/TiBluetoothUtils.m
Outdated
| @@ -26,6 +26,22 @@ @implementation TiBluetoothUtils | |||
| return result; | |||
| } | |||
|
|
|||
| + ( NSArray<NSUUID *> * _Nullable)NSUUIDArrayFromStringArray:(NSArray<id> *)array | |||
There was a problem hiding this comment.
Should be (NSArray<NSString *> *)array, since the type must always be an NSString.
iphone/Classes/TiBluetoothUtils.m
Outdated
| NSMutableArray<NSUUID*> *result = [NSMutableArray array]; | ||
|
|
||
| for (id uuid in array) { | ||
| ENSURE_TYPE(uuid, NSString); |
There was a problem hiding this comment.
Change to NSString *uuid and remove the ENSURE_TYPE.
Signed-off-by: wilson <[email protected]>
Signed-off-by: wilson <[email protected]>
|
Thanks for pointing out! |
hansemannn
approved these changes
Jun 21, 2017
|
New release tagged and docs updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: