Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use incrementMetric instead of incrementCounter #4

Merged
merged 3 commits into from
Oct 16, 2021

Conversation

petenathan42
Copy link
Contributor

@petenathan42 petenathan42 commented Oct 15, 2021

incrementCounter does not exist in https://firebase.google.com/docs/reference/android/com/google/firebase/perf/metrics/Trace
so use incrementMetric instead

also, incrementMetric requires the 2nd param (long incrementBy)

@m1ga
Copy link
Collaborator

m1ga commented Oct 15, 2021

Nice, thanks! I'll have a look soon.

@m1ga m1ga self-assigned this Oct 15, 2021
@m1ga
Copy link
Collaborator

m1ga commented Oct 15, 2021

Can you please add the manifest file with: mindsdk: 9.0.0, version 2.0.0 and architectures: arm64-v8a armeabi-v7a x86 x86_64 and remove the lib/ folder. Otherwise it won't compile for me.

Thanks

@m1ga
Copy link
Collaborator

m1ga commented Oct 16, 2021

Works fine, received some data:
Screenshot_20211016_124815

@m1ga m1ga merged commit 30b70f1 into hansemannn:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants