Ft: add scroll phyiscs to SingleChildScrollView in ReorderableWrap #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @hanshengchiu, please let me know if you concur. Thanks. |
|
@hanshengchiu gentle reminder on this PR. Otherwise, I'll merge it as-is. Thanks in advance. |
|
@diegotori Thanks for reminding me. Kindly just merge in the future if you've reviewed. There's no need to wait for me. :) |
|
@hanshengchiu very well. I'll remember that for next time. Can you please push out a new pub.dev release since I'm too busy tonight to do so. Otherwise, I'll carve out some time to release. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
When using the
ReorderableWrapwidget there was someClampingScrollPhysicsvisible when testing on an Android device, even though the wrap was not scrollable. Hence it would be nice to adjust the scroll physics of the SingleChildScrollView in which thewrappedChildrenare placed.Love to get any feedback. @hanshengchiu