fix: Hide auth diagnostics behind --debug to avoid polluting JSON out…

…put. (esnet#1087) Fixes esnet#1086. While here, fix wording of an error message.
hanvari · Jul 3, 2021 · b286f82 · b286f82
1 parent e3d86bb
commit b286f82
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/iperf_api.c b/src/iperf_api.c
@@ -1746,12 +1746,16 @@ int test_is_authorized(struct iperf_test *test){
 	}
         int ret = check_authentication(username, password, ts, test->server_authorized_users, test->server_skew_threshold);
         if (ret == 0){
-            iperf_printf(test, report_authentication_succeeded, username, ts);
+            if (test->debug) {
+              iperf_printf(test, report_authentication_succeeded, username, ts);
+            }
             free(username);
             free(password);
             return 0;
         } else {
-            iperf_printf(test, report_authentication_failed, username, ts);
+            if (test->debug) {
+                iperf_printf(test, report_authentication_failed, username, ts);
+            }
             free(username);
             free(password);
             return -1;

diff --git a/src/iperf_locale.c b/src/iperf_locale.c
@@ -281,7 +281,7 @@ const char report_connecting[] =
 "Connecting to host %s, port %d\n";
 
 const char report_authentication_succeeded[] =
-"Authentication successed for user '%s' ts %ld\n";
+"Authentication succeeded for user '%s' ts %ld\n";
 
 const char report_authentication_failed[] =
 "Authentication failed for user '%s' ts %ld\n";