New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compatible with eslint-webpack-plugin #1

Merged

haoqunjiang merged 1 commit into haoqunjiang:master from fangbinwei:soda-fork-pr

Dec 10, 2020

Collaborator

fangbinwei commented Nov 22, 2020

compatible with eslint-webpack-plugin. it seems this plugin groups eslint-loader's errors as Module Error before. So now grouping eslint-webpack-plugin's error as transformers/esLintError.js at least.

eslint-loader will emit multi-errors according to the number of files with errors. eslint-webpack-plugin will gather and throw only one compilation.errors/warnings. It is caused by the difference between loader and plugin in some degree.

change 1 errors to 1 error

when using eslint-loader:

When using eslint-webpack-plugin before this pr:

When using eslint-webpack-plugin after this pr: :

Maybe this plugin is outdated, I'm not sure if there is a good substitute.


          feat: compatible with eslint-webpack-plugin

82c4657

haoqunjiang approved these changes

View reviewed changes

haoqunjiang merged commit 60dcf38 into haoqunjiang:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet