Fix deepEqual() skip. Closes #337

hapijs · Sep 28, 2019 · 5ac20bc · 5ac20bc
1 parent 17c85a0
commit 5ac20bc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/deepEqual.js b/lib/deepEqual.js
@@ -237,10 +237,15 @@ internals.isDeepEqualObj = function (instanceType, obj, ref, options, seen) {
         return false;
     }
 
+    let skipped = 0;
     for (const key of objKeys) {
         if (options.skip &&
             options.skip.includes(key)) {
 
+            if (ref[key] === undefined) {
+                ++skipped;
+            }
+
             continue;
         }
 
@@ -253,6 +258,12 @@ internals.isDeepEqualObj = function (instanceType, obj, ref, options, seen) {
         }
     }
 
+    if (!options.part &&
+        objKeys.length - skipped !== keys(ref).length) {
+
+        return false;
+    }
+
     // Check symbols
 
     if (options.symbols !== false) {                                // Defaults to true

diff --git a/test/index.js b/test/index.js
@@ -1748,6 +1748,9 @@ describe('deepEqual()', () => {
         expect(Hoek.deepEqual({ a: 1, b: 2, [sym]: 3 }, { a: 1, b: 2 })).to.be.false();
         expect(Hoek.deepEqual({ a: 1, b: 2, [sym]: 3 }, { a: 1, b: 2 }, { skip: [sym] })).to.be.true();
         expect(Hoek.deepEqual({ a: 1, b: 2, [sym]: 3, [Symbol('other')]: true }, { a: 1, b: 2 }, { skip: [sym] })).to.be.false();
+
+        expect(Hoek.deepEqual({ a: 1, b: 2 }, { a: 1 }, { skip: ['a'] })).to.be.false();
+        expect(Hoek.deepEqual({ a: 1 }, { a: 1, b: 2 }, { skip: ['a'] })).to.be.false();
     });
 
     it('handles circular dependency', () => {