Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for dynamic channels #24

Closed
wants to merge 2 commits into from
Closed

Conversation

kamerat
Copy link

@kamerat kamerat commented Feb 27, 2019

Fixes #13

  • Added a way to add dynamic channels.
  • Fixed better checks for correct channel input
  • Moved beforeDestroy to mounted as a programmatic listener to cut down on validation code
  • Refactored some pre ES6 function declarations to arrow functions (there was a mix of both):
    function () {...} -> () => {...}

@happyDemon
Copy link
Owner

thanks for the PR, I'll check things out when I get home and get a build ready

@kamerat
Copy link
Author

kamerat commented Apr 12, 2019

Hey, @happyDemon! Sorry if I'm bothering you with this.
Do you have some time to spare to review the PR? :)
Have a nice easter, my dude. 🐣

@wardy484
Copy link

wardy484 commented May 5, 2019

😅 I was about to create a PR for this extact thing. 👍 Would be great if this was merged.

@kamerat
Copy link
Author

kamerat commented Feb 23, 2022

Closing due to inactivity ⌚

@kamerat kamerat closed this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using 'this' in channel:'user.' + this.user.id
3 participants