Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HQM-403): safe sign for personal_sign/eth_sign methods #1878

Merged
merged 4 commits into from
Apr 30, 2024
Merged

feat(HQM-403): safe sign for personal_sign/eth_sign methods #1878

merged 4 commits into from
Apr 30, 2024

Conversation

iGroza
Copy link
Collaborator

@iGroza iGroza commented Apr 30, 2024

Fixes #

Proposed Changes

  • detect phishing message sign request and block it

Checklist

@iGroza iGroza requested a review from a team as a code owner April 30, 2024 10:39
@iGroza iGroza enabled auto-merge April 30, 2024 10:45
ragozin-nikita
ragozin-nikita reviewed Apr 30, 2024
View reviewed changes
src/components/json-rpc-sign-info.tsx Outdated Show resolved Hide resolved
src/components/json-rpc-sign-info.tsx Outdated Show resolved Hide resolved
src/components/settings/settings-security/settings-security.tsx Outdated Show resolved Hide resolved
src/contexts/app.ts Outdated Show resolved Hide resolved
src/helpers/phishing-message-checker.ts Outdated Show resolved Hide resolved
@iGroza iGroza self-assigned this Apr 30, 2024
@iGroza iGroza requested a review from ragozin-nikita April 30, 2024 11:02
@iGroza iGroza added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit e1d45db Apr 30, 2024
5 checks passed
@iGroza iGroza deleted the feat/safe-personal-message-sign branch April 30, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ragozin-nikita ragozin-nikita ragozin-nikita approved these changes

Assignees

@iGroza iGroza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iGroza @ragozin-nikita