Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Setup MMKV as default storage for persistance #2203

Merged
merged 2 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ import {App} from './src/app';
import './src/event-actions';
import {Jailbreak} from './src/jailbreak';
import {Language} from '@app/models/language';
import {configurePersistable} from 'mobx-persist-store';
import {storage} from '@app/services/mmkv';

configurePersistable({storage});

LogBox.ignoreAllLogs();
if (!global.BigInt) {
const BigInt = require('big-integer');
Expand Down
3 changes: 2 additions & 1 deletion src/helpers/get-mm-phishing-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {PhishingController} from '@metamask/phishing-controller';

export const getMMPhishingController = () => {
return new PhishingController({
//@ts-ignore\
messenger: {
registerActionHandler: () => {},
unregisterActionHandler: () => {},
Expand All @@ -25,7 +26,7 @@ export const getMMPhishingController = () => {
): void {
throw new Error('Function not implemented.');
},
// @ts-expect-error
//@ts-ignore
'#private': undefined,
},
});
Expand Down
2 changes: 0 additions & 2 deletions src/models/banner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {makeAutoObservable} from 'mobx';
import {makePersistable} from 'mobx-persist-store';

import {Color} from '@app/colors';
import {storage} from '@app/services/mmkv';

import UUID = Realm.BSON.UUID;

Expand Down Expand Up @@ -69,7 +68,6 @@ class BannerStore {
makePersistable(this, {
name: this.constructor.name,
properties: ['banners'],
storage: storage,
});
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/models/browser-permission.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {Alert} from 'react-native';

import {app} from '@app/contexts';
import {I18N, getText} from '@app/i18n';
import {storage} from '@app/services/mmkv';
import {
BrowserPermissionItem,
BrowserPermissionStatus,
Expand All @@ -31,7 +30,6 @@ class BrowserPermissionStore {
name: this.constructor.name,
// @ts-ignore
properties: ['_data'],
storage: storage,
});
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/models/contact.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {isHydrated, makePersistable} from 'mobx-persist-store';
import {awaitForRealm} from '@app/helpers/await-for-realm';
import {realm} from '@app/models';
import {ContactRealmObject} from '@app/models/realm-object-for-migration';
import {storage} from '@app/services/mmkv';
import {MobXStoreFromRealm} from '@app/types';
import {STORE_REHYDRATION_TIMEOUT_MS} from '@app/variables/common';

Expand All @@ -30,7 +29,6 @@ class ContactStore implements MobXStoreFromRealm {
makePersistable(this, {
name: this.constructor.name,
properties: ['contacts'],
storage: storage,
});
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/models/currencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {Wallet} from '@app/models/wallet';
import {Backend} from '@app/services/backend';
import {Balance} from '@app/services/balance';
import {Indexer} from '@app/services/indexer';
import {storage} from '@app/services/mmkv';
import {RemoteConfig} from '@app/services/remote-config';
import {ChainId, RatesResponse} from '@app/types';
import {createAsyncTask} from '@app/utils';
Expand All @@ -33,7 +32,6 @@ class CurrenciesStore {
name: this.constructor.name,
//@ts-ignore
properties: ['_currencies', '_selectedCurrency'],
storage: storage,
}).finally(() => runInAction(() => (this._isInited = true)));
} else {
runInAction(() => (this._isInited = true));
Expand Down
11 changes: 2 additions & 9 deletions src/models/error-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,8 @@ import {ModalType} from '@app/types';
type ErrorType = 'sssLimitReached';

class ErrorHandlerStore {
constructor(shouldSkipPersisting: boolean = false) {
constructor() {
makeAutoObservable(this);
if (!shouldSkipPersisting) {
// makePersistable(this, {
// name: this.constructor.name,
// properties: [''],
// storage: storage,
// });
}
}

notifySentry = (
Expand Down Expand Up @@ -58,5 +51,5 @@ class ErrorHandlerStore {
};
}

const instance = new ErrorHandlerStore(Boolean(process.env.JEST_WORKER_ID));
const instance = new ErrorHandlerStore();
export {instance as ErrorHandler};
2 changes: 0 additions & 2 deletions src/models/language.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {NativeModules, Platform} from 'react-native';

import {setLanguage, supportedTranslationsMap} from '@app/i18n';
import {Backend} from '@app/services/backend';
import {storage} from '@app/services/mmkv';
import {AppLanguage, Language as LanguageType} from '@app/types';

class LanguageStore {
Expand Down Expand Up @@ -35,7 +34,6 @@ class LanguageStore {
name: this.constructor.name,
//@ts-ignore
properties: ['current', 'keys', 'hash'],
storage: storage,
});
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/models/provider/provider-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {makePersistable} from 'mobx-persist-store';

import {Indexer} from '@app/services/indexer';
import {ProviderConfig} from '@app/services/indexer/indexer.types';
import {storage} from '@app/services/mmkv';
import {ChainId} from '@app/types';

import {Provider} from './provider';
Expand All @@ -18,7 +17,6 @@ class ProviderConfigStore {
makePersistable(this, {
name: this.constructor.name,
properties: ['_data'] as (keyof this)[],
storage: storage,
});
}

Expand Down
2 changes: 0 additions & 2 deletions src/models/provider/provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {hideModal, showModal} from '@app/helpers';
import {awaitForEventDone} from '@app/helpers/await-for-event-done';
import {EthRpcEndpointAvailability} from '@app/helpers/eth-rpc-endpoint-availability';
import {Backend, NetworkProvider} from '@app/services/backend';
import {storage} from '@app/services/mmkv';
import {WalletConnect} from '@app/services/wallet-connect';
import {ModalType} from '@app/types';
import {createAsyncTask, sleep} from '@app/utils';
Expand Down Expand Up @@ -60,7 +59,6 @@ class ProviderStore {
makePersistable(this, {
name: this.constructor.name,
properties: ['_selectedProviderId', '_data'],
storage: storage,
});
}

Expand Down
2 changes: 0 additions & 2 deletions src/models/raffles.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {makeAutoObservable, toJS} from 'mobx';
import {makePersistable} from 'mobx-persist-store';

import {storage} from '@app/services/mmkv';
import {MobXStore, Raffle} from '@app/types';

class RafflesStore implements MobXStore<Raffle> {
Expand All @@ -12,7 +11,6 @@ class RafflesStore implements MobXStore<Raffle> {
name: this.constructor.name,
// @ts-ignore
properties: ['_data'],
storage: storage,
});
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/models/socket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {makePersistable} from 'mobx-persist-store';

import {AddressUtils} from '@app/helpers/address-utils';
import {Wallet} from '@app/models/wallet';
import {storage} from '@app/services/mmkv';
import {RPCMessage} from '@app/types/rpc';

const HEARTBEAT_INTERVAL_MS = 10_000;
Expand All @@ -22,7 +21,6 @@ class SocketStore {
name: this.constructor.name,
//@ts-ignore
properties: ['data'],
storage: storage,
});
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/models/stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import BlastedImage from 'react-native-blasted-image';
import convertToProxyURL from 'react-native-video-cache';

import {Backend} from '@app/services/backend';
import {storage} from '@app/services/mmkv';
import {IStory} from '@app/types';

class StoriesStore {
Expand All @@ -19,7 +18,6 @@ class StoriesStore {
name: this.constructor.name,
//@ts-ignore
properties: ['data'],
storage: storage,
});
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/models/tokens.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {Socket} from '@app/models/socket';
import {IWalletModel, Wallet} from '@app/models/wallet';
import {Balance} from '@app/services/balance';
import {Indexer, IndexerAddressesResponse} from '@app/services/indexer';
import {storage} from '@app/services/mmkv';
import {
AddressEthereum,
AddressType,
Expand Down Expand Up @@ -127,7 +126,6 @@ class TokensStore implements MobXStore<IToken> {
},
},
],
storage: storage,
}).then(() => {
// Logger.log('TokensStore data', JSON.stringify(this.data, null, 2));
});
Expand Down
2 changes: 0 additions & 2 deletions src/models/wallet/wallet.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {awaitForEventDone} from '@app/helpers/await-for-event-done';
import {Socket} from '@app/models/socket';
import {Balance} from '@app/services/balance';
import {Indexer, IndexerUpdatesResponse} from '@app/services/indexer';
import {storage} from '@app/services/mmkv';
import {RPCMessage, RPCObserver} from '@app/types/rpc';
import {deepClone} from '@app/utils';
import {
Expand Down Expand Up @@ -91,7 +90,6 @@ class WalletStore implements RPCObserver {
},
},
],
storage: storage,
});
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/models/whitelist/whitelist.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {Provider, ProviderModel} from '@app/models/provider';
import {Token} from '@app/models/tokens';
import {Wallet} from '@app/models/wallet';
import {Indexer} from '@app/services/indexer';
import {storage} from '@app/services/mmkv';
import {RemoteConfig} from '@app/services/remote-config';
import {AddressType, IContract, VerifyAddressResponse} from '@app/types';
import {MAINNET_ETH_CHAIN_ID} from '@app/variables/common';
Expand Down Expand Up @@ -39,7 +38,6 @@ class Whitelist {
makePersistable(this, {
name: this.constructor.name,
properties: ['urls', 'contracts'],
storage,
expireIn: CACHE_LIFE_TIME,
});
}
Expand Down