Support org.w3c.dom.Document input to SVGImageReader #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanio
commented
Dec 31, 2022
imageio/imageio-batik/src/main/java/com/twelvemonkeys/imageio/plugins/svg/SVGImageReader.java
Outdated
Show resolved
Hide resolved
|
Just noticed there's a previous #452. It is slightly different from my suggestion here – it appears to perform some unnecessary hoops for |
Allow reading an SVG source once, and tweak its content in memory like changing viewBox, colors, and styles to produce multiple image variants in succession. See "DynamicSvgOffscreen - Rendering a dynamic SVG document to an offscreen buffer" (Batik HowTos) <https://cwiki.apache.org/confluence/display/XMLGRAPHICSBATIK/DynamicSvgOffscreen>
Handle DOM exceptions to signal IIOException. Avoid unexpected unchecked exception popping up.
|
Thanks! I'll look into the changes as soon as I find the time! |
Declare SVG_ROOT QName instead of just the namespace.
Extract SVGImageReaderSpi DOM tests into separate class/suite.
Replace unintended DocumentBuilderFactory.newDefaultInstance() (Java 9+) usage -> DocumentBuilderFactory.newInstance(), in tests.
haraldk
added a commit
that referenced
this pull request
Jun 5, 2023
haraldk
added a commit
that referenced
this pull request
Jul 19, 2023
(cherry picked from commit ba1f754)
|
@haraldk, I'm not looking into this anymore. Please close it at your discretion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: Allow reading an SVG source once, and tweaking its content in memory like changing viewBox, colors, and styles to produce multiple image variants in succession.
Similar to: DynamicSvgOffscreen - Rendering a dynamic SVG document to an offscreen buffer (Batik HowTos)