Prefer IsEmpty over Count/Any #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
commented
Feb 24, 2023
| internal ICollection<WaitTask> WaitTasks { get; set; } | ||
| internal ConcurrentSet<WaitTask> WaitTasks { get; set; } |
There was a problem hiding this comment.
Changing the type of this internal property was necessary to get access to IsEmpty at line 146.
Reported by CA1836
|
Can you add that to the ruleset? |
Sure! |
A PR with that upgrade is welcome! We can mark all failing rules as |
Merged
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roslyn Aanalyzers reports CA1836: Prefer IsEmpty over Count when available.
E.g.
ConcurrentDictionary.IsEmptyhas a lock-free fast path, whereasConcurrentDictionary.Countalways acquires all locks.