Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two commits related to timing:
Date.now()
is documented asC#
DateTime.Now
on the other hand is documented as:If running a test while changing from/to DST, the difference between two calls to
DateTime.Now
is no longer only an approximation of the time to run some code, but also the difference in UTC offsets.By changing usages of
DateTime.Now
toDateTime.UtcNow
we remove that "race-condition" and brings the intention closer to the puppeteer tests.The second commit includes idea from #2090 (comment) to avoid silently ignoring exceptions in some tests.
@amaitland I did see your wish for a more elegant solution, but do you agree that including the less pretty solution for now is better than keeping status quo?