Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser - Dispose of ScreenshotTaskQueue when async dispose #2116

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Browser - Dispose of ScreenshotTaskQueue when async dispose #2116

merged 1 commit into from
Mar 27, 2023

Conversation

amaitland
Copy link
Contributor

The ScreenshotTaskQueue is currently only disposed when Dispose() is called, doesn't appear to be disposed when DisposeAsync is called.

kblok
kblok approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kblok kblok merged commit 776561e into hardkoded:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kblok kblok kblok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amaitland @kblok