forked from SDWebImage/SDWebImage
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes Issue:538 - Memory problem/leak on iOS 7
This was happening as the decompressed images take up lot of memory on older iOS devices such as iPad 2 with a collection view and crashes the app without a memory warning most of the times. These options don't break existing features but adds: * Adds Queue options to SDWebImagePrefetcher. * Adds option to decompress images in cache and post download.
- Loading branch information
Harish Krishnamurthy
committed
Dec 30, 2014
1 parent
21656fa
commit ed64e00
Showing
8 changed files
with
40 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed64e00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harishkashyap any chance you could merge some of the other solid PRs into your fork? Going to switch over to your fork.
https://github.com/rs/SDWebImage/pull/988/files
Some other candidates
SDWebImage#997
SDWebImage#1004
SDWebImage#985
ed64e00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing.
ed64e00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rromanchuk I am waiting to hear from @Jur4s.
ed64e00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rromanchuk tested SDWebImage#997 out. unfortunately for us, this slows the loading on collection views. I think its a multi threading problem which requires much deeper investigation than wrapping the start function with the main_sync_safe method. So I can't add this to the fork. Others are looking good.