Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpc] Improve json decode #3704

Merged
merged 1 commit into from
May 16, 2021
Merged

Conversation

AlexiaChen
Copy link
Contributor

@AlexiaChen AlexiaChen commented May 14, 2021

Issue

Operational Checklist

  1. Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?. (If no, skip to question 8.)

    NO

  2. Does this PR introduce backward-incompatible changes NOT related to on-disk data structure and/or over-the-wire protocol? (If no, continue to question 11.)

    NO

  3. Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?

NO

@AlexiaChen AlexiaChen added enhancement New feature or request rpc RPC or API labels May 14, 2021
@AlexiaChen AlexiaChen changed the title Improve json decode [rpc] Improve json decode May 14, 2021
@AlexiaChen AlexiaChen changed the title [rpc] Improve json decode [WIP] [rpc] Improve json decode May 14, 2021
@AlexiaChen AlexiaChen changed the title [WIP] [rpc] Improve json decode [rpc] Improve json decode May 14, 2021
Copy link
Contributor

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase go.mod

@AlexiaChen AlexiaChen force-pushed the improve-json-decode branch from 01f4a2a to 3af4780 Compare May 15, 2021 00:27
replace std json to json Iter

Fix CI failure
@AlexiaChen AlexiaChen force-pushed the improve-json-decode branch from 3af4780 to d0b4926 Compare May 15, 2021 00:30
@LeoHChen LeoHChen merged commit d1fc8f8 into harmony-one:main May 16, 2021
@AlexiaChen AlexiaChen deleted the improve-json-decode branch May 17, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rpc RPC or API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants