Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#41
Ideally Harmony could say that e.g. the GAD-7 is e.g. 60% similar to the PHQ-9
See Colab notebook on WMD (Word Movers Distance):
https://github.com/harmonydata/experiments/blob/main/harmony_wmd_experiment.ipynb
I tried coming up with a way of scoring the instrument vs instrument similarity since this has been discussed a number of times.
I wanted to find a way of going from the matrix of cosine scores, to a similarity between two instruments.
I put my experiments here:
https://github.com/harmonydata/h_score/blob/main/experiment_with_different_h_score_metrics.ipynb
I could not think of a coherent way of describing this in an email, but we can discuss at some point.
I think I have an acceptable way of calculating the instrument vs instrument cosine similarity, which is basically getting the crosswalk table, and averaging the values in it, and dividing by the number of items that should have been matched.
My conditions are that:
If we do this, we can get two measures of similarity between instruments - since one instrument may have 100 items and one instrument has 10, the similarity is not symmetric, so my formula that I'm proposing gives us a separate similarity metric in both directions (I called them precision and recall, since that's the terminology used in NLP when you have a query and you are trying to retrieve a document), and we can average them to get an overall similarity metric (called the F1 score, also a term that is used in NLP for the mean of precision and recall).
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
test_instrument_to_instrument_similarity.py
Since the Harmony Python package is used by the Harmony API (which is itself used by the R library and the web app), we need to avoid making any changes that break the Harmony API. Please also run the Harmony API unit tests and check that the API still runs with your changes to the Python package: https://github.com/harmonydata/harmonyapi
Test Configuration
Checklist
requirements.txt
,pyproject.toml
and also in therequirements.txt
in the API repoOptionally: feel free to paste your Discord username in this format:
discordapp.com/users/yourID
in your pull request description, then we can know to tag you in the Harmony Discord server when we announce the PR.