Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes #21

Closed
5 tasks done
harpocrates opened this issue May 13, 2017 · 0 comments
Closed
5 tasks done

Attributes #21

harpocrates opened this issue May 13, 2017 · 0 comments
Labels
bug
Milestone
0.1.0.0

Comments

@harpocrates
Copy link
Owner

harpocrates commented May 13, 2017 •
edited
Loading

Attributes are currently sometimes not parsed, not printed, and not tested. The following needs to happen:

  • go through the parser to find where attributes ought to be parsed. To do this, see which nodes on the AST support attributes and then figure out where those attributes fit in concrete syntax.
  • add test case files in sample-sources specifically for this as part of rustc-tests (since attributes are constantly evolving).
  • fix Diff to support attributes
  • modify the rustc-tests to also check that pretty-print and re-parse is a no-op; this will check that attributes are properly pretty-printed.
  • update the AST form of attributes (relevant PR)
@harpocrates harpocrates added this to the 0.1.0.0 milestone May 13, 2017
harpocrates added a commit that referenced this issue May 14, 2017
@harpocrates
Squashing miscallaneous TODOs
2335398 
Highlights:

  * apart from #21, all TODOs in 'Language.Rust.Pretty.Internal' are handled
  * all TODOs in 'Language.Rust.Pretty.Resolve' are handled (although the module is still...
    dubious)
  * patterns in the Happy grammar now use OverloadedStrings. This should provide a slight
    performance gain: the has comparision can be used before checking characters.
harpocrates added a commit that referenced this issue May 14, 2017
@harpocrates
Squashing miscallaneous TODOs
297b26b 
Highlights:

  * apart from #21, all TODOs in 'Language.Rust.Pretty.Internal' are handled
  * all TODOs in 'Language.Rust.Pretty.Resolve' are handled (although the module is still...
    dubious)
  * patterns in the Happy grammar now use OverloadedStrings. This should provide a slight
    performance gain: the has comparision can be used before checking characters.
harpocrates added a commit that referenced this issue May 17, 2017
@harpocrates
Parse range expressions
736aab3 
All range expressions that `rustc` accepts are now also accepted by the
parser (and in the same way). However, this does not mean that the
parser will reject everything that `rustc` does. See #22.

Fixed some TODOs too - the parser is done except for #21.
harpocrates added a commit that referenced this issue May 19, 2017
@harpocrates
Completed Diff tests
8d96f32 
Fixed all of the TODOs in Diff tests, notably adding support for
diffing attributes (see #21). As part of this, I turned on -Wall
for tests too, and fixed all of the warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.1.0.0
Development

No branches or pull requests
1 participant
@harpocrates