Ensure pyzmq and redis also installed with pip2 for Python 2 #15
Conversation
Previously, pyzmq and redis were pip installed using the default pip, which was for Python 3. This resulted in the pyzmq and redis packages not being found when the MISP server spawned the mispzmq script using the default python, which is version 2. With this commit, pyzmq and redis would be installed for both Python 2 (via pip2) and Python 3 (via pip3), which should allow the packages to be available to scripts which use it from different Python versions.
|
@jbarlow-mcafee Have you checked that there are no collisions between the two? If so - I have no problem in merging this. |
|
@ventz I did try this out with a custom build of the Dockerfile and saw that the mispzmq script was working fine with MISP ZeroMQ after the change. I don't believe it should be a problem to have these packages installed for both Python 2 and 3 at the same time. Even though it did not appear that pyzmq and redis needed to be installed under Python 3 in order for the mispzmq script to work, I figured it would probably be best to continue to have them installed for Python 3 for any custom modules running under Python 3 that might need to use them. Does that sound reasonable to you? Thanks! |
|
@jbarlow-mcafee Ok - and yes it does. Thanks - merging. |
…e - thanks to @jbarlow-mcafee for discovering and proposing fixes
Previously, pyzmq and redis were pip installed using the default pip,
which was for Python 3. This resulted in the pyzmq and redis packages
not being found when the MISP server spawned the mispzmq script using
the default python, which is version 2. With this commit, pyzmq and
redis would be installed for both Python 2 (via pip2) and Python 3
(via pip3), which should allow the packages to be available to scripts
which use it from different Python versions.